Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerance for periodic face search. #749

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

lijas
Copy link
Collaborator

@lijas lijas commented Jun 29, 2023

I had a mesh which were not perfectly aligned, so I had to lower the search tolerance when matching the periodic faces. I just add the tolerance as a keyword for the user to set

@lijas lijas requested a review from fredrikekre June 29, 2023 11:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch coverage: 91.20% and project coverage change: -0.13 ⚠️

Comparison is base (2b6f9b1) 92.31% compared to head (f1743d0) 92.19%.

❗ Current head f1743d0 differs from pull request most recent head 74cc8b1. Consider uploading reports for the commit 74cc8b1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
- Coverage   92.31%   92.19%   -0.13%     
==========================================
  Files          30       30              
  Lines        4527     4623      +96     
==========================================
+ Hits         4179     4262      +83     
- Misses        348      361      +13     
Impacted Files Coverage Δ
src/PointEval/point_values.jl 97.36% <ø> (ø)
src/deprecations.jl 51.31% <0.00%> (-0.69%) ⬇️
src/Grid/grid.jl 92.59% <70.00%> (-0.15%) ⬇️
src/iterators.jl 84.37% <75.00%> (-3.96%) ⬇️
src/FEValues/face_values.jl 98.13% <77.77%> (-1.87%) ⬇️
src/interpolations.jl 96.53% <85.10%> (-1.36%) ⬇️
src/Dofs/DofHandler.jl 93.98% <91.83%> (+1.54%) ⬆️
ext/FerriteMetis.jl 100.00% <100.00%> (ø)
src/Dofs/ConstraintHandler.jl 95.97% <100.00%> (ø)
src/Dofs/DofRenumbering.jl 91.30% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fredrikekre fredrikekre merged commit 2ad29cc into master Jul 4, 2023
6 checks passed
@fredrikekre fredrikekre deleted the eb_periodic_tol branch July 4, 2023 10:17
@fredrikekre fredrikekre removed their request for review July 4, 2023 10:17
AbdAlazezAhmed pushed a commit to AbdAlazezAhmed/Ferrite.jl that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants