Topology vroom 1 #753
Merged
Topology vroom 1 #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
==========================================
- Coverage 92.31% 91.26% -1.05%
==========================================
Files 30 32 +2
Lines 4527 4650 +123
==========================================
+ Hits 4179 4244 +65
- Misses 348 406 +58
☔ View full report in Codecov by Sentry. |
koehlerson
reviewed
Jun 30, 2023
koehlerson
reviewed
Jun 30, 2023
koehlerson
reviewed
Jun 30, 2023
Co-authored-by: Maximilian Köhler <[email protected]>
|
Still slow and unfortunately I introduced quite a bit of fluctuation in runtime. |
|
Since this topology is specific to some AMR algorithms I will try to add a different topology struct which will hopefully be faster to construct in the future. |
koehlerson
approved these changes
Jul 4, 2023
|
Clearer squashed commit message would be nice the next time :) |
|
Whoopsie, will do next time! |
AbdAlazezAhmed
pushed a commit
to AbdAlazezAhmed/Ferrite.jl
that referenced
this pull request
Jul 11, 2023
* Separate topology from grid. * Split up topology. * Remove todo. * Enhanced type stability. * Stop topology from overflowing my terminal buffer. * Optimize algorithm for topology construction by eliminating allocations. * Update variable names. * Update variable names 2. * Derp. * Fix oopsie. * Matrices :) * Replace last dict in topology with vector, too. * Fix bug. * Update exports. * Add note about broken mixed-dimensional queries. * Update field docs. * Update doc reference * Lazy face skeleton. * Update src/Grid/topology.jl Co-authored-by: Maximilian Köhler <[email protected]> * More tweaks. * Rename as requested. * Oopsie * Rename in tests. * Missing dispathc. * asdf * Remove algebraic stuff on EntityNeighborhood. --------- Co-authored-by: Maximilian Köhler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the topology construction algorithm and separates additional stuff like stencil and skeleton construction from the topology struct. I will add an interface for mixed-dimensional stuff in a subsequent PR, because I am not sure on the design. We can either add the mixed-dimensional stuff directly to the topology or to a different topology.
Resolves #617 mostly. We should be able to replace the sparse matrices for edges and faces with something more efficient, but I doubt that this will result in a significant runtime boost (however it will certainly be less memory-hungry).