Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for face -> facet changes #919

Closed
fredrikekre opened this issue May 19, 2024 · 4 comments · Fixed by #940
Closed

Changelog for face -> facet changes #919

fredrikekre opened this issue May 19, 2024 · 4 comments · Fixed by #940
Milestone

Comments

@fredrikekre
Copy link
Member

fredrikekre commented May 19, 2024

#914 is missing changelog entries for user-facing changes:

  • getfaceset -> getfacetset, addfaceset! -> addfacetset!
  • addboundaryfaceset! -> addboundaryfacetset!
  • getedgeset, addedgeset!, addboundaryedgeset
    No direct replacement, but Ferrite.create_edgeset and Ferrite.create_boundaryedgeset gives equivalent functionality (for 3d cases) for sets not stored in the grid.
  • FaceValues -> FacetValues
  • AbstractFacetValues -> AbstractFacetValues (why is this exported?)
  • Ferrite.getcurrentface -> Ferrite.getcurrentfacet
  • FaceQuadratureRule -> FacetQuadratureRule
  • nfaces -> nfacets
  • FaceIterator -> FacetIterator
  • FaceCache -> FacetCache
  • collect_periodic_faces -> collect_periodic_facets
  • PeriodicFacePair -> PeriodicFacetPair (why is this exported?)

Anything else?

@fredrikekre fredrikekre added this to the v1.0.0 milestone May 19, 2024
@KnutAM
Copy link
Member

KnutAM commented May 19, 2024

(Edited the list above)

Technically Ferrite.n_faces_per_cell -> Ferrite.n_facets_per_cell as well, but this is not used/tested and seems to only be overloaded for the SmallGrid. Will open PR to remvoe this completely.

@termi-official
Copy link
Member

Yea, I would also vote for removing such "global" queries on the grid, since they cause more harm than good. Or we rename then to "max_faces_per_cell" or smth, which could be used to create buffers which are "large enough".

@KnutAM
Copy link
Member

KnutAM commented May 20, 2024

Removed in #921

@KnutAM KnutAM linked a pull request May 23, 2024 that will close this issue
@KnutAM
Copy link
Member

KnutAM commented May 23, 2024

Closed in #940

@KnutAM KnutAM closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants