Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mock for bankplus module of finschia-sdk #116

Open
da1suk8 opened this issue Feb 6, 2024 · 0 comments
Open

Make mock for bankplus module of finschia-sdk #116

da1suk8 opened this issue Feb 6, 2024 · 0 comments

Comments

@da1suk8
Copy link
Member

da1suk8 commented Feb 6, 2024

Description

The current version of wasmd depends on the bankplus feature, which is an original functionality of the finschia-sdk.
Since the finschia-sdk is currently undergoing a version bump, we will use mocks to handle this dependency in the meantime.

This PR related to Finschia/finschia-sdk#1195, Finschia/finschia-sdk#1212

The parts that use bankplus are located in the following files:

  • app/app.go
  • appplus/app.go
  • x/wasm/keeper/genesis_test.go
  • x/wasm/keeper/options_test.go
  • x/wasm/keeper/test_common.go
  • x/wasmplus/keeper/genesis_test.go
  • x/wasmplus/keeper/keeper.go
  • x/wasmplus/keeper/test_common.go

The NewBaseKeeper interface will be modified as follows:

Before:
func NewBaseKeeper(
	cdc codec.Codec, storeKey sdk.StoreKey, ak types.AccountKeeper, paramSpace paramtypes.Subspace,
	blockedAddr map[string]bool, deactMultiSend bool,
) BaseKeeper
After: 
func NewBaseKeeper(
	cdc codec.Codec, storeService store.KVStoreService, ak types.AccountKeeper,
	blockedAddr map[string]bool, deactMultiSend bool, authority string, logger log.Logger,
) BaseKeeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant