feat(firebase_auth_web): add support for confirmPasswordReset
#2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slightfoot
force-pushed
the
fix_missing_confirm_pass
branch
2 times, most recently
from
3858dc9
to
82e1bcf
Compare
|
@slightfoot any chance of |
slightfoot
force-pushed
the
fix_missing_confirm_pass
branch
from
82e1bcf
to
4a78d5a
Compare
|
@domesticmouse hey Brett. Long time. Done and pushed. Sorry mate thought it was formatted. |
|
Thanks Simon, and yeah, it’s been way too long! |
Closed
Salakar
approved these changes
May 25, 2020
Salakar
changed the title
confirmPasswordReset
|
This has now been published. Thanks |
ditman
reviewed
May 27, 2020
Comment on lines
+360
to
+361
|
|
||
| Future<void> confirmPasswordReset( |
ditman
reviewed
May 27, 2020
| @@ -357,4 +357,10 @@ class FirebaseAuthWeb extends FirebaseAuthPlatform { | |||
| // See https://github.com/flutter/flutter/issues/46021 | |||
| throw UnimplementedError('verifyPhoneNumber'); | |||
| } | |||
|
|
|||
| Future<void> confirmPasswordReset( | |||
| String app, String oobCode, String newPassword) async { | |||
There was a problem hiding this comment.
Adding a trailing comma after newPassword may yield a more pleasing formatting (like this one).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
confirmPasswordResetimplementation tofirebase_auth_web. Currently missing.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
/cc @hterkelsen
/cc @bparrishMines