Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device icons for service manager #39

Open
aminalhazwani opened this issue Sep 24, 2018 · 4 comments
Open

Device icons for service manager #39

aminalhazwani opened this issue Sep 24, 2018 · 4 comments

Comments

@aminalhazwani
Copy link
Collaborator

aminalhazwani commented Sep 24, 2018

From Ryan F on Slack:

With Firefox on the Fire TV, we should have a TV icon in the Device and Service manager… How is this attempt? (mine)

image 1

For context, a screenshot and the issue mozilla/fxa-content-server#6506

image

Other explorations we did:

image 2

And another feedback from Ryan G

we'll need to reconsider some of the other integrated apps on the devices list too, to go along nicely with those... (Lockbox, Notes, etc.)

@aminalhazwani aminalhazwani changed the title Device icons for service mananager Device icons for service maneger Sep 24, 2018
@aminalhazwani aminalhazwani changed the title Device icons for service maneger Device icons for service manager Sep 24, 2018
@shane-tomlinson
Copy link

This is amazing! Thanks @aminalhazwani!

@ryanfeeley
Copy link

@aminalhazwani I mocked these up, not sure they hold up at 2x size. Pretty chunky.
image

Maybe we don't need full on responsive icons but I think what we have is closer to what we need than doubling our current icons.

Looping in @shorlander too.

@shorlander
Copy link

Yeah, the line weight was designed for small icons, it wasn't necessarily designed to for larger icons.

@ryanfeeley
Copy link

@shorlander How's this? (right)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants