Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: disable prefer-default-export #612

Open
s-pic opened this issue Oct 30, 2020 · 2 comments
Open

eslint: disable prefer-default-export #612

s-pic opened this issue Oct 30, 2020 · 2 comments

Comments

@s-pic
Copy link
Collaborator

s-pic commented Oct 30, 2020

What is the problem you want to see solved?

ME AS A DEV WANT TO
disable the enforcement of eslints´s prefer-default-export
BECAUSE
using named exports brings benefits and we are trying to bypass the rule in all sorts of places already
image

What is the solution you want to propose?

  • disable the rule
  • remove respective eslint-disable statements
@s-pic s-pic added the good first issue Good for newcomers label Oct 30, 2020
@cafca
Copy link
Collaborator

cafca commented Nov 3, 2020

Interesting point. My plan was always to remove all these eslint-disable statements eventually and refactor to default exports only. But maybe you're right and we should do the opposite. Does the auto completion work for you without default exports vs with them?

@ohrie
Copy link
Contributor

ohrie commented Jan 24, 2022

@s-pic As I can see, this issue is already done:

fixmy.frontend/.eslintrc

Line 120 in b9cde7b

"import/prefer-default-export": ["off"],

Am I missing something?

@ohrie ohrie removed the good first issue Good for newcomers label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cafca @ohrie @s-pic