Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG ]"Required" field in custom tool is not sent to LLM. #3232

Closed
me-tetr opened this issue Sep 22, 2024 · 1 comment · Fixed by #3258
Closed

[BUG ]"Required" field in custom tool is not sent to LLM. #3232

me-tetr opened this issue Sep 22, 2024 · 1 comment · Fixed by #3258
Labels
bug Something isn't working

Comments

@me-tetr
Copy link

me-tetr commented Sep 22, 2024

Describe the bug
"Required" field in custom tool is not sent to LLM. This leads to a very weird behaviour - if not ALL the fields are present (including the ones declared as not required) an agent does not use the tool and instead tells me that the instructions have been successfully completed. I've tried various approaches such as saying that the field is optional or not required in the description field.

To Reproduce
Steps to reproduce the behavior:
1 - create a custom tool. mark some fields as not required and send them over to your favourite llm.
2 - analyse via langsmith
3- look at metadata sent to llm
4- see that agent confirms action whilst not really calling the tool

Expected behavior
The agent should invoke the tool when all required

Screenshots

Screenshot 2024-09-22 at 17 04 17
Screenshot 2024-09-22 at 17 03 32
Screenshot 2024-09-22 at 17 02 46
Screenshot 2024-09-22 at 16 56 17

Setup

  • Installation :pnpm start
  • Flowise Version - 2.1.1
  • OS: mac os
  • Browser chrome
@HenryHengZJ
Copy link
Contributor

ahh I see, so the required should only contains those we ticked required on the custom tool

@HenryHengZJ HenryHengZJ added the bug Something isn't working label Sep 25, 2024
@HenryHengZJ HenryHengZJ linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants