Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose AggregateNetworkObjects via api #601

Closed
7 tasks done
greenape opened this issue Apr 9, 2019 · 1 comment · Fixed by #607
Closed
7 tasks done

Expose AggregateNetworkObjects via api #601

greenape opened this issue Apr 9, 2019 · 1 comment · Fixed by #607
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Apr 9, 2019 •
edited by OwlHute
Loading

  • Refactor AggregateNetworkObjects to take TotalNetworkObjects as main argument
  • Create new marshmallow spec file under server/query_schemas
  • Add newly created spec to FlowMachineQuerySchema
  • Add function to flowclient.client
  • Add function to flowclient.__init__
  • Add test to integration_tests/tests/test_queries.py
  • Add docs/source/4-developer.md with newly added query
@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine labels Apr 9, 2019
@OwlHute
Copy link
Contributor

OwlHute commented Apr 10, 2019 •
edited
Loading

What parameters are to be exposed for this route in flowclient ? For now I've assumed start_date, end_date, and aggregation_unit. But I can easily add other parameters.

@OwlHute OwlHute mentioned this issue Apr 10, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aggregate network objects Flowminder/FlowKit
2 participants
@greenape @OwlHute