Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Improve exception messages -> dont start with because #72

Open
mhsdesign opened this issue Jun 30, 2023 · 0 comments
Open

TASK: Improve exception messages -> dont start with because #72

mhsdesign opened this issue Jun 30, 2023 · 0 comments

Comments

@mhsdesign
Copy link
Contributor

Many exceptions are currently thrown like:

                    throw new PropertyIgnoredException(
                        sprintf(
                            'Because property is not declared in NodeType. Got value `%s`.',
                            json_encode($propertyValue)
                        ),
                        1685869035209
                    );

Property "nonDeclaredProperty" in NodeType "Flowpack.NodeTemplates:Content.SomeExceptions" | PropertyIgnoredException(Because property is not declared in NodeType. Got value "hi"., 1685869035209)

This provides not the best output for editors. A fully readable text would be better than starting with Because

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant