Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not "zoom to fit" after rotating an image (when image is in portrait format) #242

Open
patric82 opened this issue Nov 8, 2016 · 2 comments

Comments

@patric82
Copy link

patric82 commented Nov 8, 2016

I fixed it by replacing

self._currentZoom = ui ? ui.value : self._currentZoom;

with

self._currentZoom = Math.max(self.options.viewport.height / self.elements.preview.height, ui ? ui.value : self._currentZoom);

on row 499

Theres probably a better fix, but this "works on my machine" :)

capture

@Hesesses
Copy link

any official updates on this?

@thedustinsmith
Copy link
Contributor

I'm not really seeing the issue from the screenshot, but there's some zooming/boundary fixes in 2.5.2. Maybe this is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants