Set glyph widths automatically #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endtwist
added a commit
that referenced
this pull request
Jul 3, 2013
Set glyph widths automatically
|
This looks good, thanks for submitting the pull request. I didn't know about the 'autoWidth' method. Merged and will deploy it in the next point release :) |
|
This should be an option. I am using multicolor icons by positioning two glyphs on top of each other. With autoWidth this is not really possible any more. |
|
So, how this works now? |
|
Actually this seems able to produce only tall glyphs, but not long ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fontcustom sets every glyph width to 512.
That's a problem: a right-pointing chevron might have a width of 200, for instance; and when the glyph is set in a
text-align: right;container, we'd expect it to align all the way to the right.The solution is to let fontforge figure out glyph widths and write them to the font. This patch does the trick: notice, in generated svg fonts, the new "horiz-adv-x" entries.
This shouldn't have any dramatic negative consequences on users' existing fonts unless users are setting the wrong margins/paddings in their CSS because the icons have the wrong width. And if that's the case, it's probably better to fix this as soon as possible.