This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
feat #208: hide row when no visible elements #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no elements in the row are visible due to conditions being false, the row will not render an empty div. Additionally refactors the logic into a SchemaRow intermediate component, this was needed due to not being able to modify the loop. The `parsedSchema` computed MUST be used or else a refactor of the plugins would be required, so the logic had to be enclosed into a new component. closes: #208
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no elements in the row are visible due to conditions being false, the row will not render an empty div.
Additionally refactors the logic into a SchemaRow intermediate component, this was needed due to not being able to modify the loop. The
parsedSchemacomputed MUST be used or else a refactor of the plugins would be required, so the logic had to be enclosed into a new component.closes: #208
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: