Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

fix: model cleanup not working with nested schemas (fix #227) #228

Conversation

victorlambert
Copy link
Contributor

Fix #227
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good but can we make this a little bit tighter by adding a test for it?

The test should fail before you've applied your fix and should pass afterwards. You can take a look at similar tests in the packages/formvuelate/tests/unit/SchemaForm.spec.js.

Something similar to this test here:

https://github.com/formvuelate/formvuelate/blob/main/packages/formvuelate/tests/unit/SchemaForm.spec.js#L528

@victorlambert
Copy link
Contributor Author

Here you go, thanks for this great package !

Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@marina-mosti marina-mosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @victorlambert looks good

@marina-mosti marina-mosti merged commit 24be6e0 into formvuelate:main Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model cleanup on schema change does not work with nested schema
3 participants