Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

fix: default boolean false is not accepted [fixes #240] #241

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

marina-mosti
Copy link
Member

@marina-mosti marina-mosti commented Oct 5, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Closes #240
Adds the ability to use boolean false as a default value for model.
Refactors the check from a general falsey to just evaluating if the property exists in the item.

@codecov-commenter
Copy link

Codecov Report

Merging #241 (f56fefe) into main (5f368b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files           7        7           
  Lines         195      195           
  Branches       49       49           
=======================================
  Hits          185      185           
  Misses          8        8           
  Partials        2        2           

@marina-mosti marina-mosti changed the title fix: default boolean false is not accepted fixes #240 fix: default boolean false is not accepted [fixes #240] Oct 5, 2021
Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marina-mosti marina-mosti merged commit 2d52bd4 into main Oct 5, 2021
@marina-mosti marina-mosti deleted the fix/schema-model-default-false branch October 5, 2021 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values with value "false" are not added to model during initialisation
3 participants