Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add full circle support #88

Open
fabien opened this issue Jun 7, 2022 · 6 comments
Open

[Request] Add full circle support #88

fabien opened this issue Jun 7, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@fabien
Copy link

fabien commented Jun 7, 2022

As outlined here I'm using ArcWelder to prepare files for CNC cutting using a tangential knife. Apart from the former issue, the generated G2/G3 code looks pretty good.

However, perfect circles always have one larger arc (say, 90% - 95% of the perimeter) and end in a small arc or line segment. I don't think this will cause issues cutting, but I presume it should be possible to turn a perfect circle into a single G2/G3 instruction. I have tried different settings, but the circle output remains segmented in two arcs.

See: https://gist.github.com/fabien/a4d82a31fd9c1a58586d5cd45c170d42

ncviewer com_
ncviewer com_ (1)

Here's another one with a small 7mm circle, which yields a G01 at the end:

G03 I-3.482 J0.354 X47.684 Y69.181 F4000
G01 X47.737 Y69.528

ncviewer com_ (2)

@FormerLurker
Copy link
Owner

@fabien,

I may have to add an option for this, as full circles mess up 3d prints, resulting in an unacceptable overlap of filament. There is actually code to prevent full circles in arcwelder currently.

I'll think about this, and will mark it as an enhancement (including changing the title).

Thanks!

@FormerLurker FormerLurker changed the title Imperfect G2/G3 generated for full circles [Request] Add full circle support Jun 7, 2022
@FormerLurker FormerLurker added the enhancement New feature or request label Jun 7, 2022
@fabien
Copy link
Author

fabien commented Jun 7, 2022

@FormerLurker I didn't know it was a feature ;) (to prevent full circles)

Looking forward to such an enhancement (an option like --allow-circles?) Thanks for this extremely useful lib/tool!

PS will you be releasing 2.0 sometime in the near future? Hoping this will be resolved as well, as ultimately, I need to run it on Windows too.

@FormerLurker
Copy link
Owner

You can use it on windows (that's what I use to develop the tool). You just need to install the c++ runtimes first.

@fabien
Copy link
Author

fabien commented Jun 7, 2022

I see, thanks. However, the build artifacts of the v.2 action have expired. Is there another place to I download the latest binaries?

@FormerLurker
Copy link
Owner

Crap... I tell you what, give me thru the weekend and I'll try to push a build up. I'm in the middle of some modifications, and can't push the changes till those are finished. Will try to get it even sooner if I can.

@ETE-Design
Copy link

@FormerLurker V2 seems to still be Expired :-( Can you upload it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants