Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 56 and later, warning with preventDefault, react issue #54

Closed
MikeLP opened this issue Nov 2, 2016 · 7 comments
Closed

Chrome 56 and later, warning with preventDefault, react issue #54

MikeLP opened this issue Nov 2, 2016 · 7 comments
Labels

Comments

@MikeLP
Copy link

MikeLP commented Nov 2, 2016

SyntheticEvent.js:115 Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080

Actually I don't know what is this. I will investigate.

@hartzis
Copy link
Collaborator

hartzis commented Nov 23, 2016

@MikeLP Any update on this? I too see this warning in the example but it doesn't appear to be 'bad'.

@hartzis
Copy link
Collaborator

hartzis commented Jan 10, 2017

closing due to inactivity

@hartzis hartzis closed this as completed Jan 10, 2017
@RByers
Copy link

RByers commented Feb 17, 2017

As for the warning from Chrome: sorry for the trouble, this is a breaking change in Chrome 56 to improve scroll performance. There's probably a missing touch-action CSS rule, which is necessary to support touch on IE/Edge anyway.

@celsomtrindade
Copy link

I'm still getting this warning. Doesn't seem to stop anything from working. But everytime I swipe, the warning is appearing.

@hartzis
Copy link
Collaborator

hartzis commented Apr 10, 2017

track via React discussion about this facebook/react#8968

@hartzis hartzis reopened this Apr 10, 2017
@hartzis hartzis changed the title Browser throwing an error while swipe action Chrome 56 and later, warning with preventDefault, react issue Apr 10, 2017
@hartzis hartzis closed this as completed Apr 10, 2017
@hartzis
Copy link
Collaborator

hartzis commented Apr 14, 2017

if you wish to turn off scrolling/zooming inside the <Swipeable /> area you can pass a style prop to it with touch-action: none, https://developers.google.com/web/updates/2017/01/scrolling-intervention

<Swipeable style={{touchAction: 'none'}} />

Also updated readme with info. https://github.com/dogfessional/react-swipeable#chrome-56-and-later-warning-with-preventdefault

@hartzis
Copy link
Collaborator

hartzis commented Apr 30, 2017

@MikeLP would you happen to have thoughts on #69 ?

proposing changing preventDefault prop to default to false in v4 because of this chrome change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants