(vue) - Refactor lazy promise and watch effects #1162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors
useQuery
to usewatchEffect
again (see earlier commits). It then goes further to ensure that the lazy promise will always look at the latest query that has been issued. It also ensures that this latest query is shared if it's ongoing and not if it's completed. A paused query will always immediately resolve the latest result.This implementation is made a lot easier by the fact that we're resolving to the same
state
object every time. Since there's only one truth for the state, we don't need to ensure that the streams are transformed to usablescan
state like inreact-urql
.Set of changes
replayOne
operator to wrap the subject stream withswitchAll
on thereplayOne
subject streamswitchAll
thentake(1)
on thereplayOne
subject streamwatchEffect
cc @LinusBorg: This should tick all the boxes for you 🙌