Change GraphQLRequest to always contain a parsed document #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always parse the document now when we receive a string. This ensures a consistent request data structure and makes things easier, since there's not much else to expect. Also addresses a bug where `parse` is undefined. Fix #206
It needs to be exported so it ends up in the compiled typings in dist/types and it was not being used in Mutation and Subscription.
kitten
force-pushed
the
fix/always-parse-doc
branch
from
2a84d93
to
3dba2ca
Compare
andyrichardson
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always parse the document now when we receive a string.
This ensures a consistent request data structure and makes
things easier, since there's not much else to expect.
Also addresses a bug where
parseis undefined.Fix #206
Fix #219 (Related)