(core) - fix incremental fetch not bubbling up JS-errors #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8328ef6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Jan 21, 2022
| @@ -146,6 +146,14 @@ export const makeFetchSource = ( | |||
| }) | |||
| .then(complete) | |||
| .catch((error: Error) => { | |||
| if (error.name === 'SyntaxError' || error.name === 'TypeError') { | |||
There was a problem hiding this comment.
This might be a bit too limiting 😅
There was a problem hiding this comment.
Should we limit this to development?
There was a problem hiding this comment.
Well my thinking was that people using for instance Sentry in production would want to see these errors surface as well
kitten
approved these changes
Jan 21, 2022
Merged
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we introduced incremental fetch we made sure that the backwards exchanges flow could be triggered multiple times for an
OperationResultthis made it so that thefetchSourcewould actually have the backwards execution of the exchanges like GraphCache writing data, ... inside of thetry catchwhich means that if one of these throws we end up in the catch and handle this as if we encountered aGraphQLerror.fixes #2191
Set of changes
Syntax,Typeand normalErrorscenario's coming from the reverse-exchange run