(core) - Fix (cloned) mutation operation being compared rather than a stable identity #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of comparing the mutation operation's identity, we need a stand-in object, whose identity can remain stable, even as query document and other parameters are cloned and copied.
🦋 Changeset detectedLatest commit: 45ada80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
JoviDeCroock
approved these changes
Jan 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2225
Summary
This addresses a regression from #2189 where a mutation's operation is compared to filter results.
Such a comparison will always fail in the presence of cache exchanges that create new operations to update
the document of the operation (or variables)
Instead, we can introduce a stand-in identity object for the mutation instead and use that to compare.
This isn't a final resolution of the issue but a quick workaround.
Set of changes
OperationContext._identityto compare mutation identities