Remove create-react-context and bump React peer dependency #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also don't technically need the tests anymore if the hooks' tests are sufficient.
kitten
force-pushed
the
feat/drop-react-15-compat
branch
from
8ef4dff
to
79024e4
Compare
JoviDeCroock
reviewed
Jun 3, 2019
parkerziegler
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably been a mistake to include
create-react-contextand support non-hook implementations in practice. This will basically get rid of most of the maintenance burden we have right now, since we won't have to maintain two APIs for each hook/component.Fix #213