fix(react): Prevent the operation queue from being flushed during synchronous cache reads #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate between synchronous operation queue runs and scheduled/deferred queue runs by: - Using nextOperation directly for non-queue runs - Interrupting the queue when the source terminates - Always scheduling a deferred queue flush even if it'll have nothing to flush
🦋 Changeset detectedLatest commit: 5c0269d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/sync-eager-operation-queue
branch
from
67dbf79
to
5c0269d
Compare
JoviDeCroock
approved these changes
Jul 22, 2022
Merged
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2554
Don't forget to deduplicate
@urql/coreto the newest version if you do upgrade, since its fix is important.During some circumstances we may receive an update that then leads to a mount. React may decide to then recursively & synchronously continue this mount. During it, we used to then block other updates using a
currentInitflag while the component synchronously reads from the cache. However, since the cache read dispatched its operation (and then terminated), we previously then "piggybacked" off of this dispatch, and flushed other operations.This means that some potential updates could get lost if they were queued up by the update that lead to the mounted component. We instead want to prevent the queue from further being flushed when the synchronous read terminates, and always schedule a microtick that then gets another chance to flush out the queue.
We furthermore prevent recursive calls from restarting our operation queue.
This allows us to remove the
currentInitcheck entirely and prevent edge cases from causing missed updates. Such cases would always follow this pattern:The new pattern is now: