Fix error in collectTypes method #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`obj.hasOwnProperty` can sometimes be undefined even though `obj` is an actual object, see this conversation over in another repo for reference: domchristie/humps#35 I am (somehow through a million hoops) running into this in my project, and their suggested fix of using `Object.prototype.hasOwnProperty.call(obj, key)` works beautifully and fixes my issue.
kitten
approved these changes
Jul 16, 2019
JoviDeCroock
approved these changes
Jul 16, 2019
|
Any chance somebody could cut a release? 🙏 |
|
cc @andyrichardson ❓ |
|
Friendly ping we are blocked by this right now 😊 |
|
Makes sense and looks good to me! I suspect we had this conditional for TS reasons rather than runtime execution? Can't reproduce type errors on my end without the conditional so maybe this has been addressed in later updates. Either way, let's get this merged and look into that later 👍 |
|
Thank you @andyrichardson! A release would be great 🙏 |
|
@mxstbr I'll aim to get a release out tonight! |
This was referenced Jan 7, 2020
jaredpalmer
pushed a commit
to jaredpalmer/formik
that referenced
this pull request
Jan 7, 2020
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
passionSeven
added a commit
to passionSeven/formik
that referenced
this pull request
Oct 17, 2022
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
Brwonbear9241
pushed a commit
to Brwonbear9241/formilk
that referenced
this pull request
May 5, 2023
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
seniordev0312
added a commit
to seniordev0312/react-form
that referenced
this pull request
May 14, 2023
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
kstar0707
added a commit
to kstar0707/formik
that referenced
this pull request
Nov 29, 2023
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obj.hasOwnPropertycan sometimes be undefined even thoughobjis an actual object, see this conversation over in another repo for reference: domchristie/humps#35I am (somehow through a million hoops) running into this in my project, and their suggested fix of using
Object.prototype.hasOwnProperty.call(obj, key)works beautifully and fixes my issue.