Fix SSR entering infinite loop when multiple query hooks update #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug can be replicated by: - Having a `useQuery` hook in a component - Either: having a second with the same operation or another hook in the component - Triggering an update causing the component to rerender This will cause the component to rerender in SSR. The `useCallback` is a noop so some dependencies will trigger, and this will subsequently trigger another update, which then enters an infinite loop.
kitten
force-pushed
the
fix/ssr-deadlock
branch
from
8b8ba24
to
9d3d9ea
Compare
JoviDeCroock
approved these changes
Oct 29, 2019
|
Wow that's wild. I was actually hitting this yesterday working on a small NextJS app and found that changing the dependency array arbitrarily on a |
|
@parkerziegler it really is and really was hard to pin down. I'm totally aware that Edit: If anyone has some suggestions on how to improve the current |
|
:thonking-hard: 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #457
This bug can be replicated by:
useQueryhook in a componentcomponent
This will cause the component to rerender in SSR.
The
useCallbackis a noop so some dependencies will trigger,and this will subsequently trigger another update, which then
enters an infinite loop.
This is because
useCallbackis a noop in SSR: https://github.com/facebook/react/blob/0f64703edf5970b12a878ea3b5e1e30ef1d71c74/packages/react-dom/src/server/ReactPartialRendererHooks.js#L448-L454