Fix cascading cancellations from components #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonka@^4.0.0 has some improved behaviour that fixed some edge cases and bugs. As it turned out urql was relying on one of them. The switchMap in the hooks would cancel the last query and start the next. However, this cancellation cascades not only up to executeQuery to end and teardown the operation, it also flows up through the exchange pipeline, ending the entire thing like an electrical surge. This can be prevented by publishing the results chain and making sure it can never be interrupted.
This was referenced Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #501
Fix #502
(Needs to be verified)Edit: The fix was confirmed by testing against CodeSandboxes in both of the above issues 👍
wonka@^4.0.0 has some improved behaviour that fixed
some edge cases and bugs. As it turned out urql was
relying on one of them.
The switchMap in the hooks would cancel the last
query and start the next. However, this cancellation
cascades not only up to executeQuery to end and
teardown the operation, it also flows up through the
exchange pipeline, ending the entire thing like an
electrical surge.
This can be prevented by publishing the results
chain and making sure it can never be interrupted.