implement conversion for useHTTPGetForQueries #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
commented
Feb 3, 2020
kitten
reviewed
Feb 3, 2020
kitten
reviewed
Feb 3, 2020
kitten
requested changes
Feb 3, 2020
src/exchanges/fetch.ts
Outdated
| @@ -29,7 +29,7 @@ export const fetchExchange: Exchange = ({ forward }) => { | |||
| filter(op => op.operationName === 'teardown' && op.key === key) | |||
| ); | |||
|
|
|||
| return pipe(createFetchSource(operation), takeUntil(teardown$)); | |||
| return pipe(createFetchSource(operation, operation.operationName === 'query' && client.preferGetMethod), takeUntil(teardown$)); | |||
There was a problem hiding this comment.
We shouldn’t ever have to read from the client directly. Let’s move this to the operation context.
The reason for that has generally always been that the client’s option are opaque and separate from the operations and how they’re created and are dealt with in the exchange pipeline. So any option on the context can be seen, set, and manipulated by other exchanges. The same doesn’t go for the client.
To be fair, we should probably type the Client on the exchange using an interface that only contains the method we’d like to be exposed on the exchanges.
kitten
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only uncertainty (no documentation anywhere) is how to use fragments for this.