Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in calculating approximate text width - missing initial value for reduce #1644

Closed
6 tasks done
nburt opened this issue Jul 15, 2020 · 1 comment
Closed
6 tasks done

Comments

@nburt
Copy link
Contributor

nburt commented Jul 15, 2020

Bugs and Questions

Checklist

  • This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of Victory

  • I've searched open issues to make sure I'm not opening a duplicate issue

Not a duplicate issue since it's a different part of the codebase but same error with reduce as this pr: https://github.com/FormidableLabs/victory/pull/1171/files

The Problem

Describe the issue you're seeing, and what you expect the behavior to be.

I get textsize.js:229 Uncaught TypeError: Reduce of empty array with no initial value when trying to calculate the width of a label when rendering a tooltip. I think this line is just missing a ", 0" as an arg to reduce: 66fbc6f#diff-3a4bcbeba834ed0aa308dc312b106087R196

Reproduction

I was able to reproduce with a test, creating a PR shortly but wanted to have an issue to track it

Feature Requests

Checklist

  • I've read through the Docs and Guides to make sure this functionality doesn't already exist

  • I've searched open issues to make sure I'm not opening a duplicate issue

Description

Please describe the feature you're requesting in detail.

@nburt
Copy link
Contributor Author

nburt commented Jul 15, 2020

PR to fix: #1645

@boygirl boygirl closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants