Use publishr to move all build dependencies to devDependencies

[coopy]

Current task

• Implement publishr workflow in the builder-victory-component archetype.
• Make sure neither dist nor lib are in git source.
• Build both dist and lib only for git installs
• Publish both dist and lib and ensure that builder and builder-victory-component are devDependencies in "from npm" version.

Original Issue

npm install victory ends up installing webpack, builder babel-* etc.
These dependencies are required to support building lib/ in the postinstall phase when depending on Victory via a git or github URL.

If we change the postinstall script from cd lib || builder run npm:postinstall to cd lib || (npm i --development && builder run npm:postinstall), we may be able to move all these dependencies to devDependencies, to avoid punishing the majority of users who install from npm (where lib/ is already built).

[ryan-roemer]

We ideally would make this more nuanced as karma + all it's deps + phantom is a huge install...

[exogen]

Word of warning, if you try npm i --development in postinstall that npm i triggers another postinstall – ad infinitum. When we were exploring this solution a few months ago I made a project postinstall-build that handles exactly this use case.

(another note, I don't think npm i --development is a thing, but npm i --only=development is)

[coopy]

Thanks @exogen, postinstall-build is promising.

We ideally would make this more nuanced as karma + all it's deps + phantom is a huge install...

You're right, @ryan-roemer. Perhaps we could modify postinstall-build to take a blacklist argument.

[ryan-roemer]

Here's a smaller change for just swapping the two packages we care about:

• On npm publish before actual publish:
  • Move builder + builder-victory-component to devDependencies in package.json. This means package.json is dirty git-wise.
  • (OPTIONAL) Consider mutations to .npmignore. This is more critical in projects like Radium that don't publish src/, etc. to npm. The .npmignore file does control what's available even through a git install...
  • Publish to npm
  • Revert changes to package.json in git
• This is a little complicated to orchestrate with git workflows, but one strawman for an npm version workflow that should work:
  • postversion: Make dirty changes to package.json
  • postpublish: Revert dirty changes

Here's a POC for a victory component: FormidableLabs/victory-label#39 with a corresponding script / tasks in the archetype: https://github.com/FormidableLabs/builder-victory-component/compare/feature-npm-package-swapping

[ryan-roemer]

We now have https://github.com/FormidableLabs/publishr for this and should move along with that if we want to advance this ticket.

[boygirl]

closed by #415