Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components not applying theme styles #2897

Open
2 tasks done
cpresler opened this issue Sep 12, 2024 · 0 comments
Open
2 tasks done

Components not applying theme styles #2897

cpresler opened this issue Sep 12, 2024 · 0 comments
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@cpresler
Copy link
Contributor

cpresler commented Sep 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

latest

Code Sandbox link

No response

Bug report

During creation of a new theme it was found that several components are not applying styles from the theme correctly:

  • VictoryTooltip: may be a non-issue as it later appeared to be working fine, after a few builds

    • label styles are applying correctly, but none of the other styling props from the theme are being applied in the final output - flyoutStyle, flyoutPadding, cornerRadius, pointerLength, pointerWidth
  • VictoryCursorContainer:

    • does not appear to be setup to apply label styles from the theme outside of the cursorLabelComponent being a tooltip

Steps to reproduce

Apply `VictoryTheme.clean` to any of the above components and see that they are missing the styles mentioned from the theme, showing only the default `grayscale` theme values.
Demo files for the component is a good place to start.

Expected behavior

When a theme is applied the styles relating to that component would be applied.

Actual behavior

Theme styles are not applied to the components listed above.

Environment

- Device:
- OS:
- Node:
- npm:
@cpresler cpresler added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

1 participant