Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VictoryLegend in version 0.17.0 is always anchored to the top left #510

Closed
jhdielman opened this issue Mar 7, 2017 · 4 comments · Fixed by FormidableLabs/victory-core#221
Closed

VictoryLegend in version 0.17.0 is always anchored to the top left #510

jhdielman opened this issue Mar 7, 2017 · 4 comments · Fixed by FormidableLabs/victory-core#221
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable

Comments

@jhdielman
Copy link

VictoryLegend in version 0.17.0 is always anchored to the top left and doesn't seem to change. Is there a way to make this float? I have a scrollable chart and I want to be able to see the legend at all times.
@boygirl
Copy link
Contributor

boygirl commented Mar 7, 2017

@jhdielman VictoryLegend takes x and y props for positioning, but you will have to update those manually when you scroll your chart. I'm closing this issue for now, but I'm happy to re-open it if that doesn't solve your issue. You can also ask questions in the gitter channel

@boygirl boygirl closed this as completed Mar 7, 2017
@jhdielman
Copy link
Author

Many thanks @boygirl. Unfortunately, the x and y props don't seem to make a difference.

@boygirl
Copy link
Contributor

boygirl commented Mar 8, 2017

Okay, I'll check it out

@boygirl boygirl reopened this Mar 8, 2017
@boygirl boygirl added Type: Bug 🐛 Oh no! A bug or unintentional behavior Status: Needs More Info ✋ A question or report that needs more info to be addressable and removed Type: Bug 🐛 Oh no! A bug or unintentional behavior labels Mar 11, 2017
@zsherman
Copy link

+1

@boygirl boygirl mentioned this issue Mar 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix legend bugs FormidableLabs/victory-core
3 participants
@jhdielman @zsherman @boygirl