Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesomeIconProps type does not include swapOpacity (react component) #308

Closed
Toonshorty opened this issue Dec 4, 2019 · 4 comments
Closed
Assignees

Comments

@Toonshorty
Copy link

The documentation at https://www.npmjs.com/package/@fortawesome/react-fontawesome#features indicates that the property swapOpacity can be used for duotone icons.

However, the current React package (0.1.7) does not include this property in the FontAwesomeIconProps type and so the compiler will error.

@tagliala
Copy link
Member

tagliala commented Dec 4, 2019

Hi!

Thanks for being part of the Font Awesome Community.

Does this issue belong to https://github.com/FortAwesome/react-fontawesome ?

@Toonshorty
Copy link
Author

Hi @tagliala,

Apologies, I hadn't realised that there was a separate repository for the react component.

Is it possible to move this issue or do I just need to create a new one?

@tagliala
Copy link
Member

tagliala commented Dec 4, 2019

@Toonshorty don't worry, no problems.

I mean, it is just for tracking where the bug belongs to

I can transfer issues, but I can't do this issue to react-fontawesome, maybe I'm missing permissions on that repo

Let's assign @robmadole

@tagliala tagliala changed the title FontAwesomeIconProps type does not include swapOpacity FontAwesomeIconProps type does not include swapOpacity (react component) Dec 4, 2019
@robmadole robmadole transferred this issue from FortAwesome/Font-Awesome Dec 6, 2019
@robmadole
Copy link
Member

@Toonshorty I just released 0.1.8. Can you give this another try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants