Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the QR code Google API #141

Open
monperrus opened this issue Feb 19, 2020 · 5 comments
Open

implement the QR code Google API #141

monperrus opened this issue Feb 19, 2020 · 5 comments

Comments

@monperrus
Copy link

More and more apps use the QR code Google API for in-app QR code recognition.

On phones without the Google services (LineageOS, etc), this starts to be a serious problem (see microg/GmsCore#670)

What about implementing the QR code Google API?

Thanks!

@Fr4gorSoftware
Copy link
Owner

If I understood you correct, the Google API is causing problems on phones where microg services are replacing the google services. So why implementing it when it causes trouble on these smartphones? Is there any benefit in comparison to ZXing?

@monperrus
Copy link
Author

where microg services are replacing the google services.

Not replacing, we're talking of the case where google services are not installed at all on the device.

@Fr4gorSoftware
Copy link
Owner

You only list here negative points for the Google API. So why implementing it?

@Albirew
Copy link

Albirew commented Jan 8, 2021

Sorry to dig this up but ZXing repo is in maintenance mode, meaning bugfixes and changes are driven by contributed patches.
Compared to it is a google lib that is still under active dev. (btw, previous microg/GmsCore#670 issue is now fixed)

The best of two worlds would be linking to the google lib if present else falling back to ZXing.

@Tombstone2K
Copy link

Sorry to dig this up but ZXing repo is in maintenance mode, meaning bugfixes and changes are driven by contributed patches. Compared to it is a google lib that is still under active dev. (btw, previous microg/GmsCore#670 issue is now fixed)

The best of two worlds would be linking to the google lib if present else falling back to ZXing.

The fallback to another library would be cumbersome to implement I guess. Although ZXing is in maintenance mode, is there anything lacking in it, or any major bugs ?

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants