Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: hmr-client.js fails to load when inside of a srcdoc iframe #3903

Open
1 task done
KevinBrogan opened this issue May 7, 2022 · 0 comments · May be fixed by #3904
Open
1 task done

🐛 BUG: hmr-client.js fails to load when inside of a srcdoc iframe #3903

KevinBrogan opened this issue May 7, 2022 · 0 comments · May be fixed by #3904

Comments

@KevinBrogan
Copy link

Quick checklist

  • I am using the latest version of Snowpack and all plugins.

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the bug

<iframe srcdoc="<script src='someFileOnDevServer.js'></script>"></iframe>

results in an error

about:srcdoc:1 Uncaught DOMException: Failed to construct 'WebSocket': The URL 'wss:///' is invalid.
at http://localhost:8080/_snowpack/hmr-client.js:58:16

and because the exception isn't caught, the module fails to load.

Steps to reproduce

  1. Load a dev server hsotged file with HMR inside of a srcdoc iframe
  2. Error! Uncaught DOMException:

Link to minimal reproducible example (optional)

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change " location.* " references to use " new URL(document.baseURI).* " instead KevinBrogan/snowpack
1 participant
@KevinBrogan