Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Override default video player settings / Retain player settings within session #2295

Open
4 of 11 tasks
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jun 5, 2022 · 12 comments
Labels
E: ease of use improvement enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 5, 2022

Guidelines

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.

Problem Description

When #2263 was opened up. I noticed how many issues were actually opened for the same request. So here we are making a big summary.

Why do we want this? Let say in the settings i have set my default video quality to 1080p. My internet provider is giving me a hard time today so while im watching a video i switch from 1080p to 360p in the video player. The next video should also run in 360p because i just have overwriting the default quality because my provider giving me a hard time.

I could write usecases for the rest but i assume u get my point. U change it in the player for a reason.

Proposed Solution

Player buttons from the left to right, that already do this.

  • Volume
  • Playback speed
  • Captions
  • PIP
  • Theatre mode*
  • Fullwindow (can only be implemented with autoplay because u have to go out of this mode to select another video when autoplay is disabled)
  • Video Quality
  • Fullscreen
  • Dash/Legacy/Audio Formats

*There is a setting called Enable Theatre Mode by Default. When this is enabled Theatre mode will always get forced on u on the next video. If this is disabled and u switch from default view to theatre mode view in the video player. It will retain these setting.

Alternatives Considered

I do understand that some people like it that the default settings overwrite the player settings when a next video is being played. We maybe could have 2 modes?

  1. Player settings is always overwritten by default settings when another video is being player.
  2. Player settings dont get overwritten and stay like u set them to be for that session.

Issue Labels

ease of use improvement

Additional Information

I understand that this will be a difficult and long discussion. The point of this issue is to centralize the discussion to this issue instead of 8 other issues.

Allot of discussion has already taken place here.

Most important bit of discussion is the settings scope manifesto provided by @jasonhenriquez

@anonaddict
Copy link

Makes sense to keep everything for the session, if someone is watching a video playlist in full screen odds are they want to continue watching in fullscreen instead of having to focus freetube and manually fullscreen every video. Especially not if it is shorter videos like vines (if those still exist) or music (2-4 minute long videos generally)

Considering how PiP currently works I also doubt anyone watching playlists or autoplay will benefit from having to manually close PIP every video (since it blackscreens when the video switches) and reopen a new one

I don't see what usecases there would be for automatically overriding the current settings with some defaults. If anyone does have use cases that would benefit from keeping the current functionality I'd be happy to hear about them, but as things currently stand I don't see a reason to make this a toggle instead of just replacing it with the current volume functionality

@kommunarr
Copy link
Collaborator

kommunarr commented Oct 23, 2023

I'm working on a feature adding stylized radio button groups an ft-icon-button dropdown. We could use this to add radio button group toggles for these video player - changeable settings:

  • Playback Rate
  • Video Quality
  • Theater Mode
  • Fullscreen
  • Fullwindow
  • Picture in Picture

To start off, we can probably only display levels 3, 4, and 6 of the settings manifesto, as those are the easiest. 3 is just saving in component state, 4 is using stateWithSideEffects if a secondary toggle is enabled (i.e., has one particular string value) for that given feature, and 6 is how we do it normally.

@kommunarr
Copy link
Collaborator

Simpler idea: what about a toggle or checkmark on the Watch route titled something like Remember video settings throughout session?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

The default settings or if it changed?

@kommunarr
Copy link
Collaborator

Settings scope 4 on the manifesto is what I had in mind:

Another has setting changes that persist throughout the entire session but not in different sessions (i.e., how volume works currently).

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

4 seems like the most logical route to me.

@on4r4p

This comment was marked as duplicate.

@AedDev

This comment was marked as duplicate.

@toby63
Copy link

toby63 commented May 14, 2024

I think four options would be best:

  1. Standard setting: keep default (reset options every video)
  2. Standard setting: keep manually set options always (means across sessions)
  3. Standard setting: keep manually set options in one session, then reset to default
  4. Dynamic setting: add a button "keep settings", so options are kept until you unmark the button or something similar

In addition there could also be:
4.a. Keep the Settings just for the same window or playlist etc. and then reset to defaults.

@ghost

This comment was marked as duplicate.

@loopernow
Copy link

In addition there could also be: 4.a. Keep the Settings just for the same window or playlist etc. and then reset to defaults.

4.a. makes perfect sense.

@4-FLOSS-Free-Libre-Open-Source-Software

As a user, I support the implementation of full-screen mode, particularly in the context of the ongoing discussion about improving video player settings. However, there is a current issue where, in Auto Play mode, the full-screen mode is automatically exited when the next video starts. Unfortunately, this exit from full-screen mode is not detected or addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: ease of use improvement enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.
Projects
Status: To assign
Development

No branches or pull requests

8 participants