Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password protect settings #2907

Closed
3 tasks done
elshimone opened this issue Dec 3, 2022 · 4 comments · Fixed by #2932
Closed
3 tasks done

Password protect settings #2907

elshimone opened this issue Dec 3, 2022 · 4 comments · Fixed by #2932
Assignees
Labels
E: new feature enhancement New feature or request

Comments

@elshimone
Copy link
Contributor

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

I would like to password protect the settings page to prevent my child from altering the parental control settings I have applied. This was mentioned in #1456 as being desirable as a separate PR.

Proposed Solution

Add a settings panel to allow a password to be set or cleared. When a password is set, it is stored as a setting. For this use case I am unsure if we need to encrypt the password in the settings. We could use bcrypt if desired.

My preference would be to lock all the settings, as even non-sensitive settings such as "use this invidious url" can render freetube unusable and I would rather not spend time working out what had been changed by my inquisitive child.

To keep things as simple as possible I am suggesting that the password can be changed by removing an existing password and setting a new one.

image

Alternatives Considered

Please let me know if you think I should add a confirmation password field. For my use case, I would probably skip this and not encrypt the password, so that I could reset it in the settings if I forgot it.

Issue Labels

new feature

Additional Information

I am happy to work on this issue.

@elshimone elshimone added the enhancement New feature or request label Dec 3, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc

@elshimone do u want me to assign u to this?

@efb4f5ff-1298-471a-8973-3d47447115dc

Just a note: Related #1086

@elshimone
Copy link
Contributor Author

Yes please!

@efb4f5ff-1298-471a-8973-3d47447115dc

Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: new feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants