Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Broken Community post #3746

Closed
6 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jul 9, 2023 · 8 comments · Fixed by #3865
Closed
6 tasks done

[Bug]: Broken Community post #3746

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jul 9, 2023 · 8 comments · Fixed by #3865
Assignees
Labels

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jul 9, 2023

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Go to https://www.youtube.com/@LofiGirl/community
  2. scroll down until u see the post

Capture

Expected Behavior

Should look like

Capture1

Issue Labels

content not loading, visual bug

FreeTube Version

v0.18.0-nightly-3096 Beta

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

Error i see in console

Capture2

Nightly Build

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@lamemakes
Copy link
Contributor

@efb4f5ff-1298-471a-8973-3d47447115dc I can work this - are users supposed to be able to interact with content like quizzes and polls? I can't seem to vote on polls, did recreate with the quiz though.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

hi @lamemake in this example the quiz isnt visible for some reason and to fix this we need to make the post visible again. No need to make interactions with posts or polls.

If u want to look into more interaction style issues regarding to community posts u can maybe look into #3253

@lamemakes
Copy link
Contributor

Yeah I gotcha, I was working on this yesterday and think I've got a solution to both.

In terms of interaction I mean should users be able to select an option for a quiz or see what the correct option is? Like as opposed to just having a few blank boxes that don't reveal anything.

Cheers!

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 8, 2023

Umm im not behind my machine so i dont really know but users should see the same on FT as is shown on YT when u are a not logged in user

I don't think that not logged in users can interact with posts

Hope this helps, let me know if u need more info :)

@lamemakes
Copy link
Contributor

Okay great - I think polls work that way but I was able to do a quiz and get the correct answer without logging in, even though afterwards it tried to direct me to a login:

IMG_20230808_092326

The correct answer is also contained in the response in from indivious (I didn't check the local API though) so in that regard there wouldn't be any additional requests needed for this implementation.

If you though this was feasible we could either let the user take the quiz and show them when they're correct/incorrect or just highlight the correct answer right out of the gate.

Thanks for the thoughts here!

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

if we want to allow interaction it should just be local, not sending the response to youtube

So the question is, does youtube give us the answer without having to interact?

if yes: we could implement local interaction just make them buttons and show the right answer afterwards (just because youtube pings their server when you answer doesn't mean we have to)

if no: we show it the same as polls

@lamemakes
Copy link
Contributor

So the question is, does youtube give us the answer without having to interact?

Yeah I believe this is the case, as mentioned previously the individous API gives the answers in the quiz object so as long as something similar happens locally we should be fine. I'll put up a PR later today with the changes & a demo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants