Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Hide videos based on title (using regex) #4573

Open
3 tasks done
ticmaisdev opened this issue Jan 21, 2024 · 6 comments · Fixed by #4202
Open
3 tasks done

[Feature Request]: Hide videos based on title (using regex) #4573

ticmaisdev opened this issue Jan 21, 2024 · 6 comments · Fixed by #4202

Comments

@ticmaisdev
Copy link

ticmaisdev commented Jan 21, 2024

image

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Currently, we are able to hide videos from channels based on:

  • exact channel name
  • channel ID

But I judge this to not be as broad as it should be.

Proposed Solution

My suggestion is making it possible so that users can use regular expressions to hide videos based on:

  • regex for title

Alternatives Considered

Currently, we are able to hide videos from channels based on:

  1. exact channel name
  2. channel ID

But I judge this to not be as broad as it should be.

My personal use cases would be for:

It's very frustrating to be disrupted from work because autoplay ends up on one of these videos playing the same song in a loop. Not to talk about those channels making huge playlists of songs that I only really enjoy listening to a couple them.

I don't think this should be difficult to implement, considering that we already have:

  • UI for similar features
  • logic for similar features

Issue Labels

ease of use improvement, improvement to existing feature, new optional setting

Additional Information

I've made a poll and majority of people agreed upon this new feature:

check poll results

@ticmaisdev
Copy link
Author

By the way, the following feature is broken. It only ever hide the videos, but autoplay won't skip them.

image

@kommunarr
Copy link
Collaborator

By the way, the following feature is broken. It only ever hide the videos, but autoplay won't skip them.

This issue will be fixed with #4202 (80688c5).

@absidue absidue changed the title [Feature Request]: hide videos based on title (using regex) [Feature Request]: Hide videos based on title (using regex) Jan 21, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc linked a pull request Jan 21, 2024 that will close this issue
4 tasks
@kommunarr kommunarr reopened this Jan 22, 2024
@kommunarr
Copy link
Collaborator

Re-opening this as the implemented solution does not handle regex. I'd be interested if anyone knows of a program with a similar feature implemented (stored blocklist that can contain regex or non-regex strings) — there are some non-trivial UX decisions for implementing this feature properly.

@ticmaisdev
Copy link
Author

@jasonhenriquez I understand this can get a little bit complex. it's understandable if you've got higher priority tasks. also: I'm sorry for not being able to help with code.

following, there is wireframe from where you guys might get some insights from. it's based on these tools:

Untitled-2024-01-11-1037

I'll try to make something more elaborate on Figma, ASAP

excalidraw.zip

@kommunarr
Copy link
Collaborator

Thanks for the provided resources @ticmaidev and @Alexander-Wilms. I like the use of the regex string as the identifier. It would also allow for a quick dynamic way to check if each tag is a regex string without having to add an object property identifier representing which strings are regex versus non-regex. Comments aren't in scope for this feature, but there are ways to add de facto commenting inside of regex strings for those who absolutely need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

Successfully merging a pull request may close this issue.

3 participants
@kommunarr @ticmaisdev and others