problem building linux-fslc-imx on dunfell

[cpboyd]

With the recent commit changes, I now get this issue building the kernel even after removing my own bbappend files:

/home/cpboyd/9300-yocto/build_fb/tmp/work-shared/imx6qdl-iwg15-sm/kernel-source/drivers/media/platform/mxc/output/mxc_vout.c: In function 'config_disp_output':
/home/cpboyd/9300-yocto/build_fb/tmp/work-shared/imx6qdl-iwg15-sm/kernel-source/drivers/media/platform/mxc/output/mxc_vout.c:1873:16: error: 'FBINFO_MISC_USEREVENT' undeclared (first use in this function)
 1873 |  fbi->flags |= FBINFO_MISC_USEREVENT;
      |                ^~~~~~~~~~~~~~~~~~~~~
/home/cpboyd/9300-yocto/build_fb/tmp/work-shared/imx6qdl-iwg15-sm/kernel-source/drivers/media/platform/mxc/output/mxc_vout.c:1873:16: note: each undeclared identifier is reported only once for each function it appears in
  AR      net/sunrpc/built-in.a
  CC      drivers/gpu/drm/drm_hashtab.o
/home/cpboyd/9300-yocto/build_fb/tmp/work-shared/imx6qdl-iwg15-sm/kernel-source/drivers/media/platform/mxc/output/mxc_vout.c: In function 'release_disp_output':
/home/cpboyd/9300-yocto/build_fb/tmp/work-shared/imx6qdl-iwg15-sm/kernel-source/drivers/media/platform/mxc/output/mxc_vout.c:1995:16: error: 'FBINFO_MISC_USEREVENT' undeclared (first use in this function)
 1995 |  fbi->flags |= FBINFO_MISC_USEREVENT;
      |                ^~~~~~~~~~~~~~~~~~~~~

[cpboyd]

This commit removed the relevant #define from include/linux/fb.h:
Freescale/linux-fslc@49fea9d#diff-43768cc89c01c730cb119634b42dfa81

[otavio]

@zandrey can you take a look?

@cpboyd what defconfig are you using?

[cpboyd]

@otavio One based off of imx_v7_defconfig

It seems like anything including CONFIG_VIDEO_MXC_IPU_OUTPUT=y should result in this error.

[zandrey]

@cpboyd FBINFO_MISC_USEREVENT has been removed in upstream with commit 376810e5e9e148648c8b6e4aa8dc6306e9364f49.

I'd say that drivers/media/platform/mxc/output/mxc_vout.c would require same changes, since it is not present in upstream.

If you can port that patch and send it over against linux-fslc tree - that would be great, otherwise I can take over it but that might take some time, probably till the beginning of next week.

-- andrey

[zandrey]

@cpboyd I've come up with a patch in my fork for this: bffbf24c88a75f0e0979fbd6eca034e010230e57

Can you pick it up and test it? If that passes for you - I would open a PR to have it in 5.4-1.0.0-imx.

-- andrey

[cpboyd]

@zandrey The build compiled successfully. I haven't actually tested it yet

[zandrey]

@cpboyd Thanks a lot for a quick feedback!

Is it possible you test this patch in runtime? I do not have a HW to verify it, so I would need to rely on your further feedback here.

Once you can verify it is operable - I would include it also into next kernel update, together with v5.4.65 merge.

-- andrey

[cpboyd]

@zandrey It seems that my build has issues related to CONFIG_OF_OVERLAY that I'm now looking into

Edit: I forgot that I'd removed my custom patches for testing the build. Everything seems good to me

[zandrey]

@cpboyd Thanks for testing it out!

I'd queue up this patch then for next kernel update.

Cheers!
-- andrey