Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter may not need to accept an explicit type argument #19

Open
mcmire opened this issue Oct 17, 2013 · 0 comments
Open

Filter may not need to accept an explicit type argument #19

mcmire opened this issue Oct 17, 2013 · 0 comments

Comments

@mcmire
Copy link

mcmire commented Oct 17, 2013

When we build query parameters / post data for HTTP requests, if filters are given, they are serialized via a #to_s method on Filter. Filters accept a type argument so they know how to serialize themselves, but it seems like this isn't necessary -- it should be able to look at what :value is and its class to know how to serialize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant