Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix references in FPCA #634

Open
vnmabus opened this issue Oct 18, 2024 · 1 comment · May be fixed by #636
Open

Fix references in FPCA #634

vnmabus opened this issue Oct 18, 2024 · 1 comment · May be fixed by #636
Assignees
@aleexarias
Labels
documentation enhancement

Comments

@vnmabus
Copy link
Member

vnmabus commented Oct 18, 2024

The reference in FPCA is currently in a private function, and it is already formatted there.

Ideally, it should be in the class docstring, to be viewable by everyone consulting the class documentation. Moreover, it should be formatted using footcite/footbibliography.

A similar reference should be added to the FPCA example.
@aleexarias
Copy link

I want to take this issue.

@aleexarias aleexarias linked a pull request Oct 20, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleexarias aleexarias

Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update fpca references aleexarias/scikit-fda
2 participants
@vnmabus @aleexarias