Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 25, inconsistency between add_unit example call arguments and practice exercise place_unit function #981

Open
jman904 opened this issue Aug 24, 2024 · 0 comments
Labels
content Issues with the lessons, practices, including their code examples

Comments

@jman904
Copy link

jman904 commented Aug 24, 2024

Near the bottom of lesson 25 there is the following code snippet:

1 func run():
2   for cell in unit_cells:
3     var unit = unit_cels[cell]
4     add_unit(unit, cell)

I thought the arg ordering of add_unit was a little strange at first as add_unit(coordinate, unit_name) just feels more intuitive. Sure enough, in the 2nd practice example the order of the args for place_unit is in this order (i.e., place_unit(cell:Vector2, unit_type: String) ). It would probably add clarity to use the same function name, with the same argument ordering, in lesson module associated with the practice.

@jman904 jman904 added the content Issues with the lessons, practices, including their code examples label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues with the lessons, practices, including their code examples
Projects
None yet
Development

No branches or pull requests

1 participant