Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues under index.html #10

Open
krittika019 opened this issue Sep 29, 2024 · 0 comments
Open

issues under index.html #10

krittika019 opened this issue Sep 29, 2024 · 0 comments

Comments

@krittika019
Copy link

Issues Identified:
Unclosed

tag: The .back section has an incomplete tag (<div class=), which can cause issues in rendering the back of the card.
Obsolete year options in dropdown: The year options include years in the past (from 2016 to 2025), which are now outdated.
Repetitive class names in card numbers: The input-cart-number class is used for all four input fields for the card number. While this isn't a critical issue, it might cause confusion if CSS or JS is applied.
Input type num: The type should be number instead of num, as HTML recognizes number for input fields that require numeric input.
Accessibility: The for attribute in elements should match the corresponding input id, which is correctly done here, but the placeholders and roles (like aria-* attributes) for accessibility could be enhanced.
Form Validation: The novalidate attribute prevents HTML5 validation. Consider removing it if client-side validation is desired.
Hardcoded year values: Instead of hardcoding years, generating them dynamically (especially for future years) would make the code more maintainable.
CSS class conflict risk: The class name logo is generic and might conflict with other styles in a larger project. Consider a more descriptive name like card-logo.
SVG placement duplication: The SVG logo for the Visa icon is duplicated in the front and back. It might be better to define the SVG once and reference it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant