Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in index.html #12

Open
RishitPrabhu opened this issue Sep 29, 2024 · 0 comments
Open

Issues in index.html #12

RishitPrabhu opened this issue Sep 29, 2024 · 0 comments

Comments

@RishitPrabhu
Copy link

Here are the issues in your original code:

Incomplete HTML Tags:

The div tag in the back section is incomplete (<div class=).
Duplicated SVG Elements:

The same Visa logo SVG is present in both the front and back sections of the card.
Incorrect Input Types:

type="num" should be type="text" for card number inputs.
Input Length Limitations:

Each card number input field has a maxlength of 4, which might not be user-friendly.
Lack of Accessibility Features:

Inputs should have aria-labels or associated labels for better accessibility.
Unused IDs:

There are multiple input fields for card numbers, which could confuse users.
Missing Validation:

No JavaScript validation logic to ensure correct input formats.
Font Awesome Reference:

The button icon relies on Font Awesome, but there's no reference to include the library.
Form Elements:

Ensure each input has corresponding label elements for better user experience.
Responsive Design:

No mention of responsive styles for mobile view.
Hardcoded Expiration Years:
The expiration years should dynamically reflect the current year and a few years into the future.
Submit Button Functionality:
The submit button lacks any functionality or form submission handling.
Addressing these issues would improve both the functionality and usability of your checkout UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant