Format source bundle as "iife" #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107.
Changing the Rollup output format for the source bundle from
cjs(CommonJS) toiife(IIFE: Immediately-Invoked Function Expression) fixes directly using the source bundle with ascripttag and our usage in brouter-web (concatenating source bundles).Don't know if there was a specific reason to use
cjsfor the source bundle, while the minified bundle already uses theiifeformat. @TheGreatRefrigerator?I don't have a setup to test all the module loaders and bundlers, but there is still the module wrapper that supports both AMD and CommonJS using globals, so I don't see how this change could break anything.