Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename processing algorithms #148

Open
koebi opened this issue Jun 8, 2021 · 1 comment
Open

Rename processing algorithms #148

koebi opened this issue Jun 8, 2021 · 1 comment
Assignees

Comments

@koebi
Copy link
Collaborator

koebi commented Jun 8, 2021

Some processing algorithm names aren't as clear as they could be, i.e. Directions from points 1 layer.
As mentioned in #147, renaming could lead to scripts breaking downstream, so it would have to be investigated whether QGIS has a decent deprecation mechanism for these things.

In the process, the names returned by name() and displayName() should be re-considered as well.

@koebi koebi mentioned this issue Jun 8, 2021
@koebi
Copy link
Collaborator Author

koebi commented Jun 8, 2021

Regarding name() and displayName(), for ease of access this mirrors conversation from #147:

@koebi:

This will only capitalize the first letter of the name, whereas the code formerly capitalized the first letter of every word of the name:

>> "directions_from_polyline_layers".capitalize().replace('_', ' ')
'Directions from polylines layers'
>> " ".join(map(lambda x: x.capitalize(), "directions_from_polyline_layers".split('_')))
,'Directions From Polyline Layers'

This is not to say any variant is better, just something to be aware of.

@TheGreatRefrigerator

Yes i was aware of that and deliberately change it to only capitalize the first letter as it was imho better style than capitalizing all > letters (From) as in normal english sentences.
only one i would capitalize would be polyline as this should rather be the geojson variant of PolyLine or better yet the actual
Qgis layer name (LineString).
We can maybe tackle this, when we do renaming of algorithms and in turn decide how we display the name.

@koebi koebi self-assigned this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant