Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the selected provider when closing/reopening #168

Open
MichaelsJP opened this issue Mar 3, 2022 · 5 comments · May be fixed by #169
Open

Keep the selected provider when closing/reopening #168

MichaelsJP opened this issue Mar 3, 2022 · 5 comments · May be fixed by #169

Comments

@MichaelsJP
Copy link
Member

MichaelsJP commented Mar 3, 2022

Here's what I did

Add a custom provider. Select it. Close the Plugin and reopen it.


Here's what I got

The selection always switches back to the default one.


Here's what I was expecting

The last choice should be remembered.


Here's what I think could be improved

@koebi
Copy link
Collaborator

koebi commented Mar 3, 2022

Hey,
great find :)
What's your expectation of what should happen if you click the "refresh"-button next to the providers? Should it keep the selection or revert back to the "default"?

@MichaelsJP
Copy link
Member Author

IMO the "refresh" button is only pushed when a new provider was added. So I would guess we can leave it as is.

@koebi koebi linked a pull request Mar 3, 2022 that will close this issue
@TheGreatRefrigerator
Copy link
Collaborator

If we want to make it dynamic and not have to come back to the provider settings all the time, we need to do this when the dropdown value of the combobox is changed.
As the provider can also be set from the processing scripts, we need to have a similar thing for the Enums there.

This might work for the combo box.
Probably possible in a similar way for the Enums in the processing script UIs.

We could then store the active provider in the config and load it from there to also persist the choice for multiple QGIS sessions.

@koebi
Copy link
Collaborator

koebi commented Mar 3, 2022

While we could set any provider as "active" when the value of the combo box changes, I don't think this is possible for the dropdown of the processing scripts.
This could only happen when the processing algorithm is executed, so it would kinda go against this idea…

@koebi
Copy link
Collaborator

koebi commented Mar 3, 2022

Further discussion revealed, that this could also happen on closing the window, so that would mimic setting it whenever the value in the dropdown changes (unless someone has both windows open at the same time…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants