Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<str>.removesuffix() only available in Python3.9 #215

Closed
koebi opened this issue Jan 11, 2024 · 2 comments · Fixed by #217
Closed

<str>.removesuffix() only available in Python3.9 #215

koebi opened this issue Jan 11, 2024 · 2 comments · Fixed by #217
Assignees

Comments

@koebi
Copy link
Collaborator

koebi commented Jan 11, 2024

This comes from
https://ask.openrouteservice.org/t/how-to-fix-this-provider-error-problem/5649/2

<str>.removesuffix() and <str>.removeprefix() are only available in Python 3.9.

I don't know which QGIS version this corresponds to - we should find that out and decide whether we want to refactor until QGIS broadly supports 3.9 or whether we keep and set a higher min version.

@koebi
Copy link
Collaborator Author

koebi commented Jan 11, 2024

What I found out is that QGIS 3.18 bumped to Python 3.6 and QGIS 3.20 bumped to Python 3.7 and that's where we are now.

@merydian
Copy link
Collaborator

merydian commented Jan 11, 2024

If the backwards compatibility is only dependent on this line why not change it to support older versions? Doesn't seem like a lot of work to me. Is there anything else problematic with older versions?

If this only allows the Plugin to run with Python 3.9 we should probably fix this quickly, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants