Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First require of the slice #52

Open
ngurmen opened this issue Oct 10, 2022 · 0 comments
Open

First require of the slice #52

ngurmen opened this issue Oct 10, 2022 · 0 comments

Comments

@ngurmen
Copy link

ngurmen commented Oct 10, 2022

Hi,
I have a question on the first require on the slice method.
Shouldn't this require(_length + 31 >= _length, "slice_overflow"); be require(_bytes.length + 31 >= _length, "slice_overflow"); to be meaningful?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngurmen