Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log prints wrong move when using Intra-MEMC1 #531

Open
LSchwiebert opened this issue Oct 12, 2024 · 0 comments
Open

Log prints wrong move when using Intra-MEMC1 #531

LSchwiebert opened this issue Oct 12, 2024 · 0 comments
Assignees
Labels

Comments

@LSchwiebert
Copy link
Collaborator

Describe the bug

Although GOMC is set to run the correct move, the Info statement printed in the log is for the wrong move. Here is the offending code:

} else if (CheckString(line[0], "IntraMEMC-1Freq")) {
  if (stringtod(line[1]) > 0.0) {
    sys.moves.intraMemc = stringtod(line[1]);
    printf("%-40s %-4.4f \n", "Info: IntraMEMC-2 move frequency",
           sys.moves.intraMemc);
    sys.intraMemcVal.enable = true;
    sys.intraMemcVal.MEMC1 = true;
  }

The message should be: "Info: IntraMEMC-1 move frequency"

To Reproduce

Run any simulation with a configuration file that includes the statement

IntraMEMC-1Freq

with a value greater than zero.

Expected behavior

If using the Intra-MEMC1 move, the log file should print the correct move.

Screenshots

Not included as I think it's obvious.

Input files

I didn't actually run the code to find this problem -- I just stumbled across it when looking for something else in the code.

Please complete the following information:

  • OS: Any
  • Ensemble: Any that supports Intra-MEMC moves
  • Code version: 2.75 or later.

Additional context

This bug was a regression caused by the patch for issue #395.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant